[ 
https://issues.apache.org/jira/browse/AIRFLOW-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fokko Driesprong resolved AIRFLOW-2074.
---------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request #3011
[https://github.com/apache/incubator-airflow/pull/3011]

> GitHub Enterprise auth backend log broken
> -----------------------------------------
>
>                 Key: AIRFLOW-2074
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2074
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: authentication
>    Affects Versions: Airflow 2.0, 1.9.1
>            Reporter: Christian Mladenov
>            Assignee: Christian Mladenov
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> The refactor in [1] changed the logger name from {{_log}} to {{log}}, but 
> didn't update callers. Because they are still using {{_log}}, GHE login is 
> completely broken:
> {code:java}
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1982, in 
> wsgi_app
>     response = self.full_dispatch_request()
>   File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1614, in 
> full_dispatch_request
>     rv = self.handle_user_exception(e)
>   File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1517, in 
> handle_user_exception
>     reraise(exc_type, exc_value, tb)
>   File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1612, in 
> full_dispatch_request
>     rv = self.dispatch_request()
>   File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1598, in 
> dispatch_request
>     return self.view_functions[rule.endpoint](**req.view_args)
>   File "/usr/local/lib/python2.7/site-packages/flask_admin/base.py", line 69, 
> in inner
>     return self._run_view(f, *args, **kwargs)
>   File "/usr/local/lib/python2.7/site-packages/flask_admin/base.py", line 
> 368, in _run_view
>     return fn(self, *args, **kwargs)
>   File "/usr/local/lib/python2.7/site-packages/airflow/www/views.py", line 
> 674, in login
>     return airflow.login.login(self, request)
>   File 
> "/usr/local/lib/python2.7/site-packages/airflow/contrib/auth/backends/github_enterprise_auth.py",
>  line 232, in login
>     return login_manager.login(request)
>   File 
> "/usr/local/lib/python2.7/site-packages/airflow/contrib/auth/backends/github_enterprise_auth.py",
>  line 122, in login
>     _log.debug('Redirecting user to GHE login')
> NameError: global name '_log' is not defined{code}
>  
> [1] 
> https://github.com/apache/incubator-airflow/commit/a7a518902dcf1e7fd4bf477cf57cee691f181b29#diff-a1e98b59fef0a4c044aa9b1def8eee90R32
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to