[
https://issues.apache.org/jira/browse/AIRFLOW-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563312#comment-16563312
]
ASF GitHub Bot commented on AIRFLOW-2803:
-----------------------------------------
verdan commented on a change in pull request #3656: [AIRFLOW-2803] Fix all
ESLint issues
URL: https://github.com/apache/incubator-airflow/pull/3656#discussion_r206443837
##########
File path: airflow/www_rbac/static/js/clock.js
##########
@@ -18,24 +18,25 @@
*/
require('./jqClock.min');
-$(document).ready(function () {
- x = new Date();
+$(document).ready(() => {
Review comment:
Please note that most of the custom JS is written inline in .html files, and
we are not yet considering that javascript in webpack, that means, we won't be
able to transpile that javascript to ES5. (which is fine for now)
I am working on another issue to extract all inline JS from html files to
separate .js files.
https://issues.apache.org/jira/browse/AIRFLOW-2804
My suggestion would be to implement the ES6->ES5 tranpilation as part of
this issue. And once this PR gets merged, we'll be able to extract all inline
JS into separate .js files.
We already have a JIRA issue for that:
https://issues.apache.org/jira/browse/AIRFLOW-2730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix all ESLint issues
> ---------------------
>
> Key: AIRFLOW-2803
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2803
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Verdan Mahmood
> Assignee: Taylor Edmiston
> Priority: Major
>
> Most of the JS code in Apache Airflow has linting issues which are
> highlighted after the integration of ESLint.
> Once AIRFLOW-2783 merged in master branch, please fix all the javascript
> styling issues that we have in .js and .html files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
