[ 
https://issues.apache.org/jira/browse/AIRFLOW-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606034#comment-16606034
 ] 

ASF GitHub Bot commented on AIRFLOW-3022:
-----------------------------------------

ckljohn opened a new pull request #3855: [AIRFLOW-3022] Add volume mount to 
KubernetesExecutorConfig
URL: https://github.com/apache/incubator-airflow/pull/3855
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3022
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI 
changes:
   Added `volumes` and `volume_mounts` to the KubernetesExecutorConfig so 
volumes or secrets can be mount to worker pod.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   There is no Kubernetes testing suite exists.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
   Added a task to showcase the functionality.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add volume mount to KubernetesExecutorConfig
> --------------------------------------------
>
>                 Key: AIRFLOW-3022
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3022
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: executor
>    Affects Versions: 1.10.0
>            Reporter: John Cheng
>            Assignee: John Cheng
>            Priority: Minor
>             Fix For: 1.10.1
>
>
> Allows volume mount to the worker pod with executor_config.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to