kaxil commented on a change in pull request #3872: [AIRFLOW-3030] Fix doc of command line interface URL: https://github.com/apache/incubator-airflow/pull/3872#discussion_r216169908
########## File path: airflow/bin/cli.py ########## @@ -80,6 +80,11 @@ log = LoggingMixin().log +DAGS_FOLDER = settings.DAGS_FOLDER + +if "BUILDING_AIRFLOW_DOCS" in os.environ: + DAGS_FOLDER = '[AIRFLOW_HOME]/dags' Review comment: Exporting `AIRFLOW__CORE__DAGS_FOLDER=` would mess up with ReadTheDocs environment as it would change the Dags folder and hence can break it when parsing some modules that use example dags. We are already using this for `apply_defaults` decorator: https://github.com/apache/incubator-airflow/blob/f7fd78b06b24c15af3773b41ae3ecab7e48bb1ea/airflow/utils/decorators.py#L102-L105 And also in future when we might have more such issues where docs would need to be handled differently, I think this would be better than setting environment variables for each instance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
