ashb commented on issue #2598: [AIRFLOW-1595] Change to construct sqlite_hook from connection schema URL: https://github.com/apache/incubator-airflow/pull/2598#issuecomment-423131504 To resurrect an old PR: This PR might make sense, but as it is it would break any existing connections that are defined. The issue is probably around how the connections are created. If for instance I create a connection like this `airflow connections -a --conn_id foo --conn_uri sqlite://path/to/file.sqlite` then I end up with `{"host": "path", "schema": "to/file.sqlite"}` so the fix wouldn't actually help for this case either. The new options added recently (1.9.0, 1.10.0?) to be able to directly specify `--conn_host` probably make this PR as structured not needed, and a doc change in the SqliteHook all that is needed. (I'm not expecting you to do that, just commenting)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
