[
https://issues.apache.org/jira/browse/AIRFLOW-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawel Graczyk updated AIRFLOW-3250:
-----------------------------------
Description:
Current implementation of AIRFLOW-999 needs fixes.
1. Password have to stay None and not 'None' (str) in case there is no password
set, otherwise AUTH call will be send and that produces errors on connection to
Redis that does not expect authorisation calls.
2. Reference to connection should be set on get_conn hook object method rather
than on __init__
3. Method key_exists of hook object is trivial and should be removed
4. Fixes for unit tests so it deal with hook code and not related dependencies
such as Redis and DB connections.
was:
Current implementation of AIRFLOW-999 needs fixes.
1. Password have to stay None and not 'None' (str) in case there is no password
set, otherwise AUTH call will be send and that produces errors on connection to
Redis that does not expect authorisation calls.
2. Reference to connection should be set on get_conn hook object method rather
than on __init__
3. Method key_exists of hook object is trivial and should is going to be
removed
4. Fixes for unit tests so it deal with hook code and not related dependencies
such as Redis and DB connections.
> Fix for Redis Hook for not authorised connection calls.
> -------------------------------------------------------
>
> Key: AIRFLOW-3250
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3250
> Project: Apache Airflow
> Issue Type: Bug
> Components: db
> Affects Versions: 1.9.0, 1.10.0, 2.0.0
> Reporter: Pawel Graczyk
> Assignee: Pawel Graczyk
> Priority: Minor
> Fix For: 1.9.0, 1.10.0
>
>
> Current implementation of AIRFLOW-999 needs fixes.
> 1. Password have to stay None and not 'None' (str) in case there is no
> password set, otherwise AUTH call will be send and that produces errors on
> connection to Redis that does not expect authorisation calls.
> 2. Reference to connection should be set on get_conn hook object method
> rather than on __init__
> 3. Method key_exists of hook object is trivial and should be removed
> 4. Fixes for unit tests so it deal with hook code and not related
> dependencies such as Redis and DB connections.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
