ashb commented on a change in pull request #4126: [AIRFLOW-2524] More AWS SageMaker operators, sensors for model, endpoint-config and endpoint URL: https://github.com/apache/incubator-airflow/pull/4126#discussion_r230810900
########## File path: airflow/contrib/operators/sagemaker_endpoint_operator.py ########## @@ -0,0 +1,151 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from airflow.contrib.hooks.aws_hook import AwsHook +from airflow.contrib.operators.sagemaker_base_operator import SageMakerBaseOperator +from airflow.utils.decorators import apply_defaults +from airflow.exceptions import AirflowException + + +class SageMakerEndpointOperator(SageMakerBaseOperator): + + """ + Create a SageMaker endpoint. + + This operator returns The ARN of the endpoint created in Amazon SageMaker + + :param config: + The configuration necessary to create an endpoint. + + If you need to create a SageMaker endpoint based on an existed SageMaker model and an existed SageMaker + endpoint config, + + config = endpoint_configuration; + + If you need to create all of SageMaker model, SageMaker endpoint-config and SageMaker endpoint, + + config = { + 'Model': model_configuration, + + 'EndpointConfig': endpoint_config_configuration, + + 'Endpoint': endpoint_configuration + } + + For details of the configuration parameter of model_configuration, See: + https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker.html#SageMaker.Client.create_model + + For details of the configuration parameter of endpoint_config_configuration, See: + https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker.html#SageMaker.Client.create_endpoint_config + + For details of the configuration parameter of endpoint_configuration, See: + https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker.html#SageMaker.Client.create_endpoint + :type config: dict + :param aws_conn_id: The AWS connection ID to use. + :type aws_conn_id: str + :param wait_for_completion: Whether the operator should wait until the endpoint creation finishes. + :type wait_for_completion: bool + :param check_interval: If wait is set to True, this is the time interval, in seconds, that this operation waits + before polling the status of the endpoint creation. + :type check_interval: int + :param max_ingestion_time: If wait is set to True, this operation fails if the endpoint creation doesn't finish + within max_ingestion_time seconds. If you set this parameter to None it never times out. + :type max_ingestion_time: int + :param operation: Whether to create an endpoint or update an endpoint. Must be either 'create or 'update'. + :type operation: str + """ # noqa + + @apply_defaults + def __init__(self, + config, + wait_for_completion=True, + check_interval=30, + max_ingestion_time=None, + operation='create', + *args, **kwargs): + super(SageMakerEndpointOperator, self).__init__(config=config, + *args, **kwargs) + + self.config = config + self.wait_for_completion = wait_for_completion + self.check_interval = check_interval + self.max_ingestion_time = max_ingestion_time + self.operation = operation.lower() + if self.operation not in ['create', 'update']: + raise AirflowException('Invalid value! Argument operation has to be one of "create" and "update"') Review comment: ```suggestion raise AirflowException('operation must be one of "create" and "update"') ``` The built in `ValueError` is more appropriate here? (AirflowException is sort of a catch all, but doesn't have any special meaning to Airflow, so when a more specific exception type exists let's use that) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
