kaxil commented on a change in pull request #4192: [AIRFLOW-3345] Add Google
Cloud Storage (GCS) operators for ACL
URL: https://github.com/apache/incubator-airflow/pull/4192#discussion_r233995078
##########
File path: airflow/contrib/hooks/gcs_hook.py
##########
@@ -568,6 +568,104 @@ def create_bucket(self,
'Bucket creation failed. Error was: {}'.format(ex.content)
)
+ def insert_bucket_acl(self, bucket, entity, role, user_project):
+ # type: (str, str, str, str) -> None
+ """
+ Creates a new ACL entry on the specified bucket.
+ See:
https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert
+
+ :param bucket: Name of a bucket.
+ :type bucket: str
+ :param entity: The entity holding the permission, in one of the
following forms:
+ - user-userId
Review comment:
Needs indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
