[ 
https://issues.apache.org/jira/browse/AIRFLOW-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692671#comment-16692671
 ] 

ASF GitHub Bot commented on AIRFLOW-3371:
-----------------------------------------

ryanyuan opened a new pull request #4213: [AIRFLOW-3371] BigQueryHook's Ability 
to Create View
URL: https://github.com/apache/incubator-airflow/pull/4213
 
 
   1) Edit create_empty_table to take in optional 'view' dict
   2) Add unit tests for creating view
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following 
[Airflow-3371](https://issues.apache.org/jira/browse/AIRFLOW-3371) issues and 
references them in the PR title. 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   To enable BigQueryBaseCursor.create_empty_table to create view in BigQuery
   Ref: https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#view
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
      
tests.contrib.hooks.test_bigquery_hook:TestBigQueryBaseCursor.test_create_view_fails_on_exception
      
tests.contrib.hooks.test_bigquery_hook:TestBigQueryBaseCursor.test_create_view
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation 
generation needs to be added.
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> BigQueryHook's Ability to Create View
> -------------------------------------
>
>                 Key: AIRFLOW-3371
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3371
>             Project: Apache Airflow
>          Issue Type: New Feature
>            Reporter: Ryan Yuan
>            Assignee: Ryan Yuan
>            Priority: Major
>
> Modify *BigQueryBaseCursor.create_empty_table()* to take in an optional 
> 'view' parameter to create view in BigQuery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to