Fokko commented on a change in pull request #4231: [AIRFLOW-3066] Adding
support for AWS Batch parameters
URL: https://github.com/apache/incubator-airflow/pull/4231#discussion_r236091104
##########
File path: airflow/contrib/operators/awsbatch_operator.py
##########
@@ -94,11 +100,21 @@ def execute(self, context):
)
try:
- response = self.client.submit_job(
- jobName=self.job_name,
- jobQueue=self.job_queue,
- jobDefinition=self.job_definition,
- containerOverrides=self.overrides)
+ if self.parameters is None:
Review comment:
Do we need the `if` construction here? Can't we just pass None parameters?
Or do `parameters =self.parameters or {}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
