ashb commented on a change in pull request #3994: [AIRFLOW-3136] Add retry_number to TaskInstance Key property to avoid race condition URL: https://github.com/apache/incubator-airflow/pull/3994#discussion_r237008142
########## File path: airflow/contrib/executors/kubernetes_executor.py ########## @@ -453,7 +453,8 @@ def _labels_to_key(self, labels): try: return ( labels['dag_id'], labels['task_id'], - self._label_safe_datestring_to_datetime(labels['execution_date'])) + self._label_safe_datestring_to_datetime(labels['execution_date']), + labels['try_number']) Review comment: D'oh. Would someone (@vardancse? @aliaksandr-d?) be able to fix this, or at least add a test case that covers this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services