XD-DENG opened a new pull request #4255: [AIRFLOW-3239] Fix/refine tests in 
api/common/experimental/
URL: https://github.com/apache/incubator-airflow/pull/4255
 
 
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3239
   
   ### Description
   
   This is a follow up on JIRA 3239, to **further fix the unit tests**.
   
   Earlier related PRs: https://github.com/apache/incubator-airflow/pull/4074, 
https://github.com/apache/incubator-airflow/pull/4131).
   
   #### What is done in this PR
   
   - 1. Fixed (test_)trigger_dag.py by correcting its name, so it can be 
discovered by the CI.
   
   - 2. Fix (test_)mark_tasks.py
     - 2-1. properly name the file, so it can be discovered by the CI.
     - 2-2. Correct the name of sample DAG
     - 2-3. Correct the range of sample execution_dates
          (earlier one conflicts with the start_date of the sample DAG, which 
fails the test case)
     - 2-4. Skip `test_mark_tasks_subdag` when running with MySQL
          Seems something is wrong with 
`airflow.api.common.experimental.mark_tasks.set_state`. Corresponding test case 
(process subdags with `downstream=True`) works on Postgres & SQLite, but fails 
when on MySQL ("`(1062, "Duplicate entry '110' for key 'PRIMARY'")`". Example: 
https://travis-ci.org/XD-DENG/incubator-airflow/jobs/461200901). A TODO note is 
added to remind us fix it for MySQL later.
   
   - 3. Remove unnecessary lines in test_pool.py
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to