ashb commented on a change in pull request #4322: [AIRFLOW-3518] Performance
fixes for topological_sort
URL: https://github.com/apache/incubator-airflow/pull/4322#discussion_r241834740
##########
File path: airflow/models.py
##########
@@ -2662,10 +2662,15 @@ def __init__(
}
def __eq__(self, other):
- return (
- type(self) == type(other) and
- all(self.__dict__.get(c, None) == other.__dict__.get(c, None)
- for c in self._comps))
+ if (type(self) == type(other) and
+ self.task_id == other.task_id):
Review comment:
```
dag1 = DAG('dag2')
task1 = MyOp(task_id='start', dag=dag1)
dag2 = DAG('dag1')
task2 = MyOp(task_id='start', dag=dag2)
```
Will `task1 == task2`? It sort of looks like form this diff only that it
might.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
