[ https://issues.apache.org/jira/browse/AIRFLOW-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722218#comment-16722218 ]
ASF GitHub Bot commented on AIRFLOW-3447: ----------------------------------------- kaxil opened a new pull request #4323: [AIRFLOW-3447] Add 2 options for ts_nodash Macro URL: https://github.com/apache/incubator-airflow/pull/4323 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" - https://issues.apache.org/jira/browse/AIRFLOW-3447 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: Add Option to use `ts_nodash` and `ts_nodash_with_tz` macro so it gives any option to users to use it Filename. Previous users have been using `ts_nodash` for file and folder names. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Added tests ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added. - All the public functions and the classes in the PR contain docstrings that explain what it does Updated the docs ### Code Quality - [x] Passes `flake8` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Intended usage of ts_nodash macro broken with migration to new time system. > --------------------------------------------------------------------------- > > Key: AIRFLOW-3447 > URL: https://issues.apache.org/jira/browse/AIRFLOW-3447 > Project: Apache Airflow > Issue Type: Bug > Components: core > Reporter: Luka Draksler > Assignee: Kaxil Naik > Priority: Minor > Labels: easyfix > Fix For: 1.10.2 > > > Migration to timezone aware times broke the intended usage of ts_nodash macro. > ts_nodash is used in certain placeholders to create different names (table > names, cluster names...). As such it is alphanumeric only, it contains no > characters that could be deemed illegal by various naming restrictions. > Migration to new time system changed that. > As an example, this would be returned currently: > {{20181205T125657.169324+0000}} > {{before:}} > {{20181204T030000}} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)