ashb commented on issue #4325: [AIRFLOW-3528] handle socket exception with 
SFTPOperator
URL: 
https://github.com/apache/incubator-airflow/pull/4325#issuecomment-448241004
 
 
   I guessed at what error it might report. The main thing is you have 
try-inside-try, so this won't do what you expect.
   
   Additionally the error that was reporting was `'NoneType' object has no 
attribute 'open_sftp'` which means no exception is being thrown, instead 
`self.ssh_hook.get_conn() as ssh_client` is returning None.
   
   So the except you added (capturing `OSError`) won't ever get triggered.
   
   Tests :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to