[
https://issues.apache.org/jira/browse/AIRFLOW-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724353#comment-16724353
]
ASF GitHub Bot commented on AIRFLOW-3506:
-----------------------------------------
pingzh opened a new pull request #4342: [AIRFLOW-3506] use match_phrase to
query log_id in elasticsearch
URL: https://github.com/apache/incubator-airflow/pull/4342
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3506
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
We have noticed that the elasticsearch_logging_backend use match to query
the log_id from elasticsearch, which ends up getting more results from
elasticsearch. It should use match_phrase to query the log_id as a phrase since
log_id is a phrase.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fail to query log from elasticsearch
> ------------------------------------
>
> Key: AIRFLOW-3506
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3506
> Project: Apache Airflow
> Issue Type: Bug
> Components: logging
> Reporter: Ping Zhang
> Assignee: Ping Zhang
> Priority: Major
> Labels: easyfix, newbie
>
> We have noticed that the elasticsearch_logging_backend use match to query the
> log_id from elasticsearch, which ends up getting more results from
> elasticsearch. It should use match_phrase to query the log_id as a phrase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
