Repository: ambari Updated Branches: refs/heads/branch-2.4 86be23374 -> 05ecaae27
AMBARI-18389 - Config compare shows incorrect value after enabling kerberos (rzang) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/05ecaae2 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/05ecaae2 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/05ecaae2 Branch: refs/heads/branch-2.4 Commit: 05ecaae2773a2e8cdf1c5f740a7e0d9de23b0f36 Parents: 86be233 Author: Richard Zang <rz...@apache.org> Authored: Wed Sep 14 13:50:08 2016 -0700 Committer: Richard Zang <rz...@apache.org> Committed: Wed Sep 14 14:01:05 2016 -0700 ---------------------------------------------------------------------- .../app/models/configs/objects/service_config_property.js | 9 +++++++-- .../models/configs/objects/service_config_property_test.js | 2 -- 2 files changed, 7 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/05ecaae2/ambari-web/app/models/configs/objects/service_config_property.js ---------------------------------------------------------------------- diff --git a/ambari-web/app/models/configs/objects/service_config_property.js b/ambari-web/app/models/configs/objects/service_config_property.js index 2757804..8d4cef1 100644 --- a/ambari-web/app/models/configs/objects/service_config_property.js +++ b/ambari-web/app/models/configs/objects/service_config_property.js @@ -111,8 +111,13 @@ App.ServiceConfigProperty = Em.Object.extend({ /** * Placeholder used for configs with input type text */ - placeholder: Em.computed.firstNotBlank('placeholderText', 'savedValue'), - + placeholder: function() { + if (this.isEditable) { + return this.get('placeholderText') || this.get('savedValue'); + } + return null; + }.property('isEditable', 'placeholderText', 'savedValue'), + retypedPassword: '', description: '', displayType: 'string', // string, digits, number, directories, custom http://git-wip-us.apache.org/repos/asf/ambari/blob/05ecaae2/ambari-web/test/models/configs/objects/service_config_property_test.js ---------------------------------------------------------------------- diff --git a/ambari-web/test/models/configs/objects/service_config_property_test.js b/ambari-web/test/models/configs/objects/service_config_property_test.js index a6772d3..d462025 100644 --- a/ambari-web/test/models/configs/objects/service_config_property_test.js +++ b/ambari-web/test/models/configs/objects/service_config_property_test.js @@ -186,8 +186,6 @@ describe('App.ServiceConfigProperty', function () { serviceConfigProperty = getProperty(); }); - App.TestAliases.testAsComputedFirstNotBlank(getProperty(), 'placeholder', ['placeholderText', 'savedValue']); - App.TestAliases.testAsComputedAnd(getProperty(), 'hideFinalIcon', ['!isFinal', 'isNotEditable']); describe('#isPropertyOverridable', function () {
