Repository: ambari Updated Branches: refs/heads/branch-2.5 2e664f6b2 -> 2a0d22354
AMBARI-20092. Hive View 2.0: User should be shown with appropriate error message when compute statistics action fails. (dipayanb) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/2a0d2235 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/2a0d2235 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/2a0d2235 Branch: refs/heads/branch-2.5 Commit: 2a0d2235487a61a3914ef2b5dc203dff366231bf Parents: 2e664f6 Author: Dipayan Bhowmick <dipayan.bhowm...@gmail.com> Authored: Wed Feb 22 12:42:34 2017 +0530 Committer: Dipayan Bhowmick <dipayan.bhowm...@gmail.com> Committed: Wed Feb 22 12:42:34 2017 +0530 ---------------------------------------------------------------------- .../src/main/resources/ui/app/components/table-statistics.js | 5 ++++- .../resources/ui/app/routes/databases/database/tables/table.js | 2 ++ .../ui/app/routes/databases/database/tables/table/edit.js | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/2a0d2235/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js ---------------------------------------------------------------------- diff --git a/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js b/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js index 1623e0e..0310cbc 100644 --- a/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js +++ b/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js @@ -17,8 +17,9 @@ */ import Ember from 'ember'; +import UILoggerMixin from '../mixins/ui-logger'; -export default Ember.Component.extend({ +export default Ember.Component.extend(UILoggerMixin, { statsService: Ember.inject.service(), analyseWithStatistics: false, @@ -76,6 +77,7 @@ export default Ember.Component.extend({ Ember.run.later(() => this.closeAndRefresh(), 2 * 1000); }).catch((err) => { this.set('analyseMessage', 'Job failed for analysing statistics of table'); + this.get('logger').danger(`Job failed for analysing statistics of table '${tableName}'`, this.extractError(err)); Ember.run.later(() => this.closeAndRefresh(), 2 * 1000); }); }, @@ -96,6 +98,7 @@ export default Ember.Component.extend({ }).catch((err) => { column.set('isFetchingStats', false); column.set('statsError', true); + this.get('logger').danger(`Job failed for fetching column statistics for column '${column.name}' of table '${tableName}'`, this.extractError(err)); }); }, http://git-wip-us.apache.org/repos/asf/ambari/blob/2a0d2235/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js ---------------------------------------------------------------------- diff --git a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js index 6ee8100..53055cf 100644 --- a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js +++ b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js @@ -38,6 +38,8 @@ export default Ember.Route.extend(UILoggerMixin, { console.log(model.get('detailedInfo.tableType').toLowerCase()); if (model.get('detailedInfo.tableType').toLowerCase().indexOf('view') === -1) { newTabs = newTabs.rejectBy('name', 'viewInfo'); + } else { + newTabs = newTabs.rejectBy('name', 'statistics'); } controller.set('tabs', newTabs); }, http://git-wip-us.apache.org/repos/asf/ambari/blob/2a0d2235/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js ---------------------------------------------------------------------- diff --git a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js index d9f80e1..2fa61b4 100644 --- a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js +++ b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js @@ -57,7 +57,7 @@ export default TableMetaRouter.extend(UILoggerMixin, { this._transitionToTables(); }).catch((err) => { this._modalStatus(false, 'Failed to edit table'); - this.get('logger').danger(`Failed to altered table '${settings.table}'`, this.extractError(err)); + this.get('logger').danger(`Failed to alter table '${settings.table}'`, this.extractError(err)); }); }