AMBARI-20903 RepoVersion parsing error should be more specific (dili)

Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/6e2d3219
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/6e2d3219
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/6e2d3219

Branch: refs/heads/branch-feature-AMBARI-20859
Commit: 6e2d32196b065530263b1468d50d710db8b8eca5
Parents: 2b146d9
Author: Di Li <d...@apache.org>
Authored: Tue May 2 14:25:18 2017 -0400
Committer: Di Li <d...@apache.org>
Committed: Tue May 2 14:25:18 2017 -0400

----------------------------------------------------------------------
 .../ambari/server/orm/entities/RepositoryVersionEntity.java      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/6e2d3219/ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
----------------------------------------------------------------------
diff --git 
a/ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 
b/ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
index d3705f3..f5d669e 100644
--- 
a/ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
+++ 
b/ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
@@ -249,8 +249,8 @@ public class RepositoryVersionEntity {
       try {
         return 
repositoryVersionHelperProvider.get().parseOperatingSystems(operatingSystems);
       } catch (Exception ex) {
-        // Should never happen as we validate json before storing it to DB
-        LOG.error("Could not parse operating systems json stored in database:" 
+ operatingSystems, ex);
+        String msg = String.format("Failed to parse repository from OS/Repo 
information in the database: %s. Required fields: repo_name, repo_id, 
base_url", operatingSystems);
+        LOG.error(msg, ex);
       }
     }
     return Collections.emptyList();

Reply via email to