AMBARI-22258. Use correct property attribute setter fn(). while setting 'tez.runtime.io.sort.mb' maximum value.
Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/3b5cbed0 Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/3b5cbed0 Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/3b5cbed0 Branch: refs/heads/branch-3.0-perf Commit: 3b5cbed0983ef3e47b6a948dcbeeef0ac5d6a604 Parents: 37d59f2 Author: Swapan Shridhar <sshrid...@hortonworks.com> Authored: Wed Oct 18 13:05:40 2017 -0700 Committer: Swapan Shridhar <sshrid...@hortonworks.com> Committed: Wed Oct 18 13:05:40 2017 -0700 ---------------------------------------------------------------------- .../resources/common-services/YARN/3.0.0.3.0/service_advisor.py | 3 ++- .../src/main/resources/stacks/HDP/2.5/services/stack_advisor.py | 3 ++- .../src/test/python/stacks/2.5/common/test_stack_advisor.py | 5 ++++- 3 files changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/3b5cbed0/ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py ---------------------------------------------------------------------- diff --git a/ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py b/ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py index ecf245d..70eb5be 100644 --- a/ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py +++ b/ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py @@ -580,6 +580,7 @@ class YARNRecommender(service_advisor.ServiceAdvisor): putHiveInteractiveEnvProperty = self.putProperty(configurations, "hive-interactive-env", services) putHiveInteractiveEnvPropertyAttribute = self.putPropertyAttribute(configurations, "hive-interactive-env") putTezInteractiveSiteProperty = self.putProperty(configurations, "tez-interactive-site", services) + putTezInteractiveSitePropertyAttribute = self.putPropertyAttribute(configurations, "tez-interactive-site") llap_daemon_selected_queue_name = None selected_queue_is_ambari_managed_llap = None # Queue named 'llap' at root level is Ambari managed. llap_selected_queue_am_percent = None @@ -1047,7 +1048,7 @@ class YARNRecommender(service_advisor.ServiceAdvisor): putTezInteractiveSiteProperty('tez.runtime.io.sort.mb', tez_runtime_io_sort_mb) if "tez-site" in services["configurations"] and "tez.runtime.sorter.class" in services["configurations"]["tez-site"]["properties"]: if services["configurations"]["tez-site"]["properties"]["tez.runtime.sorter.class"] == "LEGACY": - putTezInteractiveSiteProperty("tez.runtime.io.sort.mb", "maximum", 1800) + putTezInteractiveSitePropertyAttribute("tez.runtime.io.sort.mb", "maximum", 1800) putTezInteractiveSiteProperty('tez.runtime.unordered.output.buffer.size-mb', tez_runtime_unordered_output_buffer_size) putHiveInteractiveSiteProperty('hive.auto.convert.join.noconditionaltask.size', hive_auto_convert_join_noconditionaltask_size) http://git-wip-us.apache.org/repos/asf/ambari/blob/3b5cbed0/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py ---------------------------------------------------------------------- diff --git a/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py index 92ce9b9..b6f2478 100644 --- a/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py +++ b/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py @@ -860,6 +860,7 @@ class HDP25StackAdvisor(HDP24StackAdvisor): putHiveInteractiveEnvProperty = self.putProperty(configurations, "hive-interactive-env", services) putHiveInteractiveEnvPropertyAttribute = self.putPropertyAttribute(configurations, "hive-interactive-env") putTezInteractiveSiteProperty = self.putProperty(configurations, "tez-interactive-site", services) + putTezInteractiveSitePropertyAttribute = self.putPropertyAttribute(configurations, "tez-interactive-site") llap_daemon_selected_queue_name = None selected_queue_is_ambari_managed_llap = None # Queue named 'llap' at root level is Ambari managed. llap_selected_queue_am_percent = None @@ -1331,7 +1332,7 @@ class HDP25StackAdvisor(HDP24StackAdvisor): putTezInteractiveSiteProperty('tez.runtime.io.sort.mb', tez_runtime_io_sort_mb) if "tez-site" in services["configurations"] and "tez.runtime.sorter.class" in services["configurations"]["tez-site"]["properties"]: if services["configurations"]["tez-site"]["properties"]["tez.runtime.sorter.class"] == "LEGACY": - putTezInteractiveSiteProperty("tez.runtime.io.sort.mb", "maximum", 1800) + putTezInteractiveSitePropertyAttribute("tez.runtime.io.sort.mb", "maximum", 1800) putTezInteractiveSiteProperty('tez.runtime.unordered.output.buffer.size-mb', tez_runtime_unordered_output_buffer_size) putHiveInteractiveSiteProperty('hive.auto.convert.join.noconditionaltask.size', hive_auto_convert_join_noconditionaltask_size) http://git-wip-us.apache.org/repos/asf/ambari/blob/3b5cbed0/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py ---------------------------------------------------------------------- diff --git a/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py b/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py index cf462de..407e78d 100644 --- a/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py +++ b/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py @@ -4446,7 +4446,8 @@ class TestHDP25StackAdvisor(TestCase): }, "tez-site": { "properties": { - "tez.am.resource.memory.mb": "1024" + "tez.am.resource.memory.mb": "1024", + "tez.runtime.sorter.class": "LEGACY" } }, } @@ -4481,6 +4482,8 @@ class TestHDP25StackAdvisor(TestCase): self.assertEqual(configurations['hive-interactive-site']['properties']['hive.llap.io.memory.size'], '186368') self.assertEqual(configurations['hive-interactive-env']['properties']['llap_heap_size'], '9830') + self.assertEqual(configurations['tez-interactive-site']['properties']['tez.runtime.io.sort.mb'], '1092') + self.assertEquals(configurations['tez-interactive-site']['property_attributes']['tez.runtime.io.sort.mb'], {'maximum': '1800'})