swagle commented on a change in pull request #5: [AMBARI-24723] Support wild
cards in AppId and InstanceId fields in AMS GET API.
URL: https://github.com/apache/ambari-metrics/pull/5#discussion_r222804628
##########
File path:
ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/PhoenixHBaseAccessor.java
##########
@@ -1990,6 +1991,106 @@ public void
saveMetricMetadata(Collection<TimelineMetricMetadata> metricMetadata
return metadataMap;
}
+ public List<TimelineMetricMetadata>
scanMetricMetadataForWildCardRequest(Collection<String> metricNames,
+
String appId,
+
String instanceId) throws SQLException {
+ List<TimelineMetricMetadata> metadataList = new ArrayList<>();
+ Connection conn = getConnection();
+ PreparedStatement stmt = null;
+ ResultSet rs = null;
+
+ MetadataQueryCondition metadataQueryCondition = new
MetadataQueryCondition(new ArrayList<>(metricNames), appId, instanceId);
Review comment:
Minor nit: Why copy the collection into a new list here? Pass down reference
of original collection instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
