zhoujinsong commented on code in PR #2824:
URL: https://github.com/apache/amoro/pull/2824#discussion_r1597340718
##########
amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/terminal/TerminalManager.java:
##########
@@ -370,7 +380,16 @@ private void applyClientProperties(CatalogMeta
catalogMeta) {
catalogMeta.putToCatalogProperties(
CatalogMetaProperties.KEY_WAREHOUSE, catalogMeta.getCatalogName());
} else if
(!catalogMeta.getCatalogProperties().containsKey(CatalogProperties.CATALOG_IMPL))
{
- catalogMeta.putToCatalogProperties("type", catalogType);
+ if (Sets.newHashSet(
Review Comment:
What I mean is we may better construct the required properties when the
catalog is created and persist them in the sysdb rather than put them every
time we use them. `AMS_URI` may be different because it may change when AMS
reboots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
