klion26 commented on code in PR #3231:
URL: https://github.com/apache/amoro/pull/3231#discussion_r1792980416
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerController.java:
##########
@@ -75,10 +76,15 @@ public void getOptimizerTables(Context ctx) {
List<TableRuntime> tableRuntimes =
tableRuntimeBeans.stream()
.map(meta -> tableService.getRuntime(meta.getTableId()))
+ .filter(Objects::nonNull)
Review Comment:
Yes, this is defensive programming, because we will process the information
we get here(TableRuntime list) later and throw Exception in
`OptimizingUtil#buildTableOptimizeInfo`), of course, we can also remove it here
if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
