Jzjsnow opened a new pull request, #3396:
URL: https://github.com/apache/amoro/pull/3396
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in
https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title,
e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related
issue
-->
When we start Amoro Management Service , we need to set configuration items
in plaintext in the config file, including sensitive configurations such as
admin-password and the passwords for connecting to databases (e.g., mysql, pg,
etc.), which may be a security risk. To avoid the use of plaintext passwords,
we provide an interface (`ConfigShade`) by implementing which developers can
customize the decryption method themselves.
We also provide an implementation for base64 encoding first, not only as an
example implementation of the interface, but also to solve the current problem
of plaintext passwords.
Close #3335.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
- Add interface `ConfigShade` to the `amoro-common` module to provide the
ability to customize decryption of sensitive options in the config file
- Provide an implementation
`org.apache.amoro.config.shade.impl.Base64ConfigShade` for base64 encoding
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs /
not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
