zhongqishang commented on code in PR #3672:
URL: https://github.com/apache/amoro/pull/3672#discussion_r2238143089
##########
amoro-format-hudi/src/main/java/org/apache/amoro/formats/hudi/HudiTableDescriptor.java:
##########
@@ -97,6 +97,8 @@ public class HudiTableDescriptor implements
FormatTableDescriptor {
private static final Logger LOG =
LoggerFactory.getLogger(HudiTableDescriptor.class);
private static final String COMPACTION = "compaction";
private static final String CLUSTERING = "clustering";
+ // table comment
+ private static final String COMMENT = "comment";
Review Comment:
Can be used `org.apache.amoro.table.TableProperties#COMMENT`.
##########
amoro-web/src/views/tables/components/Details.vue:
##########
@@ -128,7 +130,10 @@ async function getTableDetails() {
}
function setBaseDetailInfo() {
- emit('setBaseDetailInfo', state.baseDetailInfo)
+ emit('setBaseDetailInfo', {
+ ...state.baseDetailInfo,
+ comment:state.comment
+ })
Review Comment:
The code format seems to be abnormal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
