zhoujinsong commented on code in PR #3768:
URL: https://github.com/apache/amoro/pull/3768#discussion_r2342840471
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java:
##########
@@ -200,11 +200,11 @@ private void addHandlerChain(RuntimeHandlerChain chain) {
}
public void disposeOptimizingService() {
- if (tableManagementServer != null && tableManagementServer.isServing()) {
+ if (tableManagementServer != null) {
Review Comment:
It seems the codebase is out of date, comparing with the master
branch:https://github.com/apache/amoro/blob/master/amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java#L208
##########
amoro-ams/src/main/java/org/apache/amoro/server/metrics/MetricRegistry.java:
##########
@@ -78,6 +78,7 @@ public <T extends Metric> MetricKey register(
define.getName());
MetricKey key = new MetricKey(define, tags);
+ unregister(key);
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
