zhangwl9 commented on issue #3831:
URL: https://github.com/apache/amoro/issues/3831#issuecomment-3424668891
If we change `undersizedSegmentFileCount >= 2` to `enoughContent()`, it
still fails to return `true`.
As shown in its code：
CommonPartitionEvaluator.enoughContent() {
return undersizedSegmentFileSize >= config.getTargetSize()
&& min1SegmentFileSize + min2SegmentFileSize <=
config.getTargetSize();
}
This means that even if there are two 80MB files, they will not be
considered “enoughContent” if their combined size exceeds the target size
(128MB), because while the first condition is met, the second condition is not
(the sum of two 80MB files, 160MB, is greater than the target size of 128MB).
Can we change "undersizedSegmentFileCount >= 2" to
"undersizedSegmentFileSize >= config.getTargetSize()
&& min1SegmentFileSize <= config.getTargetSize() &&
min2SegmentFileSize <= config.getTargetSize()" @zhoujinsong @zhongqishang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
