zhoujinsong commented on PR #4106:
URL: https://github.com/apache/amoro/pull/4106#issuecomment-4022162985
Thanks for the improvements! The changes address real Apache release
compliance issues.
A few things to fix/clarify:
**1. `CURR_DIR` is undefined in `create_binary_release.sh`**
```bash
cd ${CURR_DIR} # CURR_DIR is never assigned
rm -rf ${EXTRACT_DIR}
```
This will cause `cd` to fail or behave unexpectedly. Please add
`CURR_DIR=$(pwd)` near the top of the script.
**2. Missing newline at end of file**
Both `create_source_release.sh` and `create_binary_release.sh` are missing a
trailing newline. POSIX requires text files to end with a newline.
**3. `git.properties` copy should fail fast if file is missing**
```bash
cp amoro-ams/target/classes/amoro/git.properties
amoro-$RELEASE_VERSION/amoro-ams/target/classes/amoro/
```
If the `mvn initialize` step fails silently or the output path changes, this
`cp` will fail with a confusing error. Consider adding an explicit check:
```bash
[ -f amoro-ams/target/classes/amoro/git.properties ] || { echo "ERROR:
git.properties not generated"; exit 1; }
```
**4. GitHub Actions workflow is missing SHA-512 checksum generation**
Apache release policy requires `.sha512` checksum files alongside the
release artifacts and `.asc` signatures. The workflow uploads `tar.gz*` (which
includes `.asc`) but I don't see a step generating `.sha512` files.
**5. Verification request**
Could you run the GitHub Actions workflow on your fork with `skip_gpg=true`
and `skip_deploy=true` to verify the end-to-end flow works? Please share the
Actions run link in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
