davedwwang commented on PR #4115:
URL: https://github.com/apache/amoro/pull/4115#issuecomment-4031623947
> The BOM version `1.21.4` is hardcoded directly in `pom.xml`. It would be
better to manage it via a property in the root `pom.xml` `<properties>`
section, consistent with how other dependency versions are managed in this
project (e.g., `mockito.version`, `iceberg.version`, etc.):
>
> ```
> <properties>
> ...
> <testcontainers.version>1.21.4</testcontainers.version>
> </properties>
>
> <dependencyManagement>
> <dependencies>
> <dependency>
> <groupId>org.testcontainers</groupId>
> <artifactId>testcontainers-bom</artifactId>
> <version>${testcontainers.version}</version>
> <type>pom</type>
> <scope>import</scope>
> </dependency>
> </dependencies>
> </dependencyManagement>
> ```
>
> This makes future version upgrades easier — only one place to change.
Thanks, I'll handle that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
