xxubai commented on code in PR #3922:
URL: https://github.com/apache/amoro/pull/3922#discussion_r2917241362
##########
docs/configuration/ams-config.md:
##########
@@ -48,6 +48,7 @@ table td:last-child, table th:last-child { width: 40%;
word-break: break-all; }
| auto-create-tags.interval | 1 min | Interval for creating tags. |
| auto-create-tags.thread-count | 3 | The number of threads used for creating
tags. |
| blocker.timeout | 1 min | Session timeout. Default unit is milliseconds if
not specified. |
+| bucket-assign.interval | 1 min | Interval for bucket assignment service to
detect node changes and redistribute bucket IDs. |
Review Comment:
Should it hava the prefix: `ha.`?
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -62,6 +62,27 @@ public class AmoroManagementConf {
"This setting controls whether to enable the AMS horizontal
scaling feature, "
+ "which is currently under development and testing.");
+ public static final ConfigOption<Integer> HA_BUCKET_ID_TOTAL_COUNT =
+ ConfigOptions.key("ha.bucket-id.total-count")
+ .intType()
+ .defaultValue(100)
+ .withDescription(
+ "Total count of bucket IDs for assignment. Bucket IDs range from
1 to this value.");
+
+ public static final ConfigOption<Duration> NODE_OFFLINE_TIMEOUT =
+ ConfigOptions.key("node-offline.timeout")
+ .durationType()
+ .defaultValue(Duration.ofMinutes(5))
+ .withDescription(
+ "Timeout duration to determine if a node is offline. After this
duration, the node's bucket IDs will be reassigned.");
+
+ public static final ConfigOption<Duration> ASSIGN_INTERVAL =
+ ConfigOptions.key("bucket-assign.interval")
Review Comment:
Do you mean:
```suggestion
ConfigOptions.key("ha.bucket-assign.interval")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
