j1wonpark commented on code in PR #4107: URL: https://github.com/apache/amoro/pull/4107#discussion_r2936371018
########## amoro-ams/src/main/java/org/apache/amoro/server/process/iceberg/IcebergProcessFactory.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.amoro.server.process.iceberg; + +import org.apache.amoro.Action; +import org.apache.amoro.IcebergActions; +import org.apache.amoro.TableFormat; +import org.apache.amoro.TableRuntime; +import org.apache.amoro.config.ConfigOption; +import org.apache.amoro.config.ConfigOptions; +import org.apache.amoro.config.Configurations; +import org.apache.amoro.process.ExecuteEngine; +import org.apache.amoro.process.LocalExecutionEngine; +import org.apache.amoro.process.ProcessFactory; +import org.apache.amoro.process.ProcessTriggerStrategy; +import org.apache.amoro.process.RecoverProcessFailedException; +import org.apache.amoro.process.TableProcess; +import org.apache.amoro.process.TableProcessStore; +import org.apache.amoro.server.table.DefaultTableRuntime; +import org.apache.amoro.shade.guava32.com.google.common.collect.Lists; +import org.apache.amoro.shade.guava32.com.google.common.collect.Maps; +import org.apache.commons.lang3.tuple.Pair; + +import java.time.Duration; +import java.util.Collection; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.stream.Collectors; + +/** Default process factory for Iceberg-related maintenance actions in AMS. */ +public class IcebergProcessFactory implements ProcessFactory { + + public static final String PLUGIN_NAME = "iceberg"; + public static final ConfigOption<Boolean> SNAPSHOT_EXPIRE_ENABLED = + ConfigOptions.key("expire-snapshots.enabled").booleanType().defaultValue(true); + + public static final ConfigOption<Duration> SNAPSHOT_EXPIRE_INTERVAL = + ConfigOptions.key("expire-snapshot.interval") Review Comment: Bug: Config key mismatch — this uses `expire-snapshot.interval` (singular) while `SNAPSHOT_EXPIRE_ENABLED` above uses `expire-snapshots.enabled` (plural). The default `process-factories.yaml` also uses the plural form `expire-snapshots.interval`, so this key will never match the YAML config and will always fall back to the default value. ```suggestion ConfigOptions.key("expire-snapshots.interval") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
