j1wonpark commented on code in PR #4141: URL: https://github.com/apache/amoro/pull/4141#discussion_r2979474585
########## amoro-format-mixed/amoro-mixed-flink/v1.19/amoro-mixed-flink-1.19/pom.xml: ########## @@ -0,0 +1,99 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.amoro</groupId> + <artifactId>amoro-mixed-flink</artifactId> + <version>0.9-SNAPSHOT</version> + <relativePath>../../pom.xml</relativePath> + </parent> + + <artifactId>amoro-format-mixed-flink-1.19</artifactId> + + <packaging>jar</packaging> + <name>Amoro Project Mixed Format Flink 1.19</name> + <url>https://amoro.apache.org</url> + + <properties> + <kafka.version>3.2.3</kafka.version> + <assertj.version>3.21.0</assertj.version> + <flink.version>1.19.1</flink.version> + </properties> + + <dependencies> + <dependency> + <groupId>org.apache.amoro</groupId> + <artifactId>amoro-mixed-flink-common</artifactId> Review Comment: Good catch. I initially kept `amoro-mixed-flink-common` pinned to 1.18 to avoid potential runtime breakage on the v1.18 module, but after reviewing the Flink 1.19 release notes there are no breaking API changes — only deprecations scheduled for Flink 2.0. Will update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
