wardlican commented on code in PR #3927: URL: https://github.com/apache/amoro/pull/3927#discussion_r2985299940
########## amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java: ########## @@ -87,19 +94,46 @@ public class DefaultTableService extends PersistentBase implements TableService private final Configurations serverConfiguration; private final CatalogManager catalogManager; private final TableRuntimeFactory tableRuntimeFactory; + private final HighAvailabilityContainer haContainer; + private final BucketAssignStore bucketAssignStore; + private final boolean isMasterSlaveMode; private RuntimeHandlerChain headHandler; private ExecutorService tableExplorerExecutors; + // Master-slave mode related fields + private ScheduledExecutorService bucketTableSyncScheduler; + private volatile List<String> assignedBucketIds = new ArrayList<>(); + private final long bucketTableSyncInterval; + // Lock for bucketId assignment to prevent concurrent assignment conflicts + private final Object bucketIdAssignmentLock = new Object(); Review Comment: Yes, there really is no need to add this lock here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
