Nam0101 opened a new pull request, #4156:
URL: https://github.com/apache/amoro/pull/4156
Hi there! 👋
While exploring the codebase, I noticed a minor opportunity for improvement
in `amoro-web/vite.config.ts`.
**Context:**
`vitePluginFakeServer` is configured with `enableProd: true`, so mock
endpoints can be active in production. This can cause the UI to always receive
successful mocked data, hiding real backend latency/failures and preventing
users from seeing real loading, empty, and error states. It also risks shipping
stale/fake data paths.
**Proposed fix:**
Disable fake server in production and gate it by mode: `export default
defineConfig(({ mode }) => ({ ... plugins: [ ... vitePluginFakeServer({
enableProd: false, ... }) ] }))` or conditionally include the plugin only when
`mode === 'development'`.
**Files changed:**
- `amoro-web/vite.config.ts` (modified)
*(Note: Tested the changes locally to ensure everything works as expected.
Let me know if you need any adjustments, happy to help!)*
——
**NamNV**
📍 Hanoi, Vietnam
📧 [email protected]
Closes #4155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
