fightBoxing opened a new pull request, #4164:
URL: https://github.com/apache/amoro/pull/4164
## Summary
- Add `createTag` and `deleteTag` API endpoints for Iceberg tables
(`POST/DELETE /ams/v1/tables/catalogs/{catalog}/dbs/{db}/tables/{table}/tags`)
- Implement tag creation and deletion logic in
`MixedAndIcebergTableDescriptor` using Iceberg `TableMetadata` API
- Add `CreateTagRequest` DTO in `TableController` to replace unsafe
`Map<String, Object>` deserialization
- Add `createTag` / `deleteTag` service functions in frontend
`table.service.ts`
- Add Create Tag modal and Delete Tag confirmation in `Selector.vue` with
snapshot ID and optional max-ref-age inputs
- Extend `FormatTableDescriptor` interface and `ServerTableDescriptor` with
tag management methods
## Test Plan
- [ ] Start Amoro server and open Web UI
- [ ] Navigate to an Iceberg table → Tags tab
- [ ] Click "Create Tag", fill in tag name and snapshot ID, confirm creation
succeeds
- [ ] Verify new tag appears in the tag list
- [ ] Click delete icon on a tag, confirm deletion succeeds
- [ ] Verify deleted tag is removed from the list
- [ ] Verify Checkstyle: 0 violations
- [ ] Verify Spotless: BUILD SUCCESS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
