Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/143#discussion_r125853623
  
    --- Diff: 
extensions/aria_extension_tosca/simple_v1_0/modeling/capabilities.py ---
    @@ -162,6 +164,30 @@ def 
convert_capability_from_definition_to_assignment(context, presentation, cont
         return CapabilityAssignment(name=presentation._name, raw=raw, 
container=container)
     
     
    +def merge_capability_definition(context, presentation, 
capability_definition,
    +                                from_capability_definition):
    --- End diff --
    
    well, i might go with it regarding the first naming issue, but this is a 
new function, why not rename its arguments properly? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to