Github user aviyoop commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/208#discussion_r152273070
  
    --- Diff: aria/orchestrator/execution_compiler.py ---
    @@ -0,0 +1,161 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +import os
    +import sys
    +from datetime import datetime
    +
    +from . import exceptions
    +from .context.workflow import WorkflowContext
    +from .workflows import builtin
    +from .workflows.core import graph_compiler
    +from .workflows.executor.process import ProcessExecutor
    +from ..modeling import models
    +from ..modeling import utils as modeling_utils
    +from ..utils.imports import import_fullname
    +
    +
    +DEFAULT_TASK_MAX_ATTEMPTS = 30
    +DEFAULT_TASK_RETRY_INTERVAL = 30
    +
    +
    +class ExecutionCompiler(object):
    --- End diff --
    
    So... Although it is not a great name as well, consider naming this 
`ExecutionPreparer` =(


---

Reply via email to