Repository: arrow Updated Branches: refs/heads/master 34e7f48cb -> 2742d37cc
ARROW-254: remove Bit type as it is redundant with Boolean The only use of Bit is for the nullability (or validity) vector which is best understood as a boolean type. We should remove it as it is not used. Author: Julien Le Dem <jul...@dremio.com> Closes #116 from julienledem/arrow_254_remove_bit_type and squashes the following commits: 1cada12 [Julien Le Dem] ARROW-254: remove Bit type Project: http://git-wip-us.apache.org/repos/asf/arrow/repo Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/2742d37c Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/2742d37c Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/2742d37c Branch: refs/heads/master Commit: 2742d37cc3f890ffd68ba46920240c18ae5528ae Parents: 34e7f48 Author: Julien Le Dem <jul...@dremio.com> Authored: Fri Aug 12 15:58:20 2016 -0700 Committer: Julien Le Dem <jul...@dremio.com> Committed: Fri Aug 12 15:58:20 2016 -0700 ---------------------------------------------------------------------- cpp/src/arrow/ipc/metadata-internal.cc | 2 -- format/Message.fbs | 4 ---- 2 files changed, 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/arrow/blob/2742d37c/cpp/src/arrow/ipc/metadata-internal.cc ---------------------------------------------------------------------- diff --git a/cpp/src/arrow/ipc/metadata-internal.cc b/cpp/src/arrow/ipc/metadata-internal.cc index 1b1d50f..5c43912 100644 --- a/cpp/src/arrow/ipc/metadata-internal.cc +++ b/cpp/src/arrow/ipc/metadata-internal.cc @@ -99,8 +99,6 @@ static Status TypeFromFlatbuffer(flatbuf::Type type, const void* type_data, return Status::Invalid("Type metadata cannot be none"); case flatbuf::Type_Int: return IntFromFlatbuffer(static_cast<const flatbuf::Int*>(type_data), out); - case flatbuf::Type_Bit: - return Status::NotImplemented("Type is not implemented"); case flatbuf::Type_FloatingPoint: return FloatFromFlatuffer( static_cast<const flatbuf::FloatingPoint*>(type_data), out); http://git-wip-us.apache.org/repos/asf/arrow/blob/2742d37c/format/Message.fbs ---------------------------------------------------------------------- diff --git a/format/Message.fbs b/format/Message.fbs index fc849ee..e0a956c 100644 --- a/format/Message.fbs +++ b/format/Message.fbs @@ -20,9 +20,6 @@ table Union { mode: UnionMode; } -table Bit { -} - table Int { bitWidth: int; // 1 to 64 is_signed: bool; @@ -62,7 +59,6 @@ table JSONScalar { union Type { Int, - Bit, FloatingPoint, Binary, Utf8,