This is an automated email from the ASF dual-hosted git repository.
uwe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 7405406 ARROW-4156: [C++] Don't use object libs with Xcode
7405406 is described below
commit 7405406928ac0e3ab03bf2091173563ed54d2a07
Author: Uwe L. Korn <uw...@xhochy.com>
AuthorDate: Fri Jan 4 19:15:35 2019 +0100
ARROW-4156: [C++] Don't use object libs with Xcode
Author: Uwe L. Korn <uw...@xhochy.com>
Closes #3308 from xhochy/ARROW-4156 and squashes the following commits:
1c76769d <Uwe L. Korn> ARROW-4156: Don't use object libs with Xcode
---
cpp/cmake_modules/BuildUtils.cmake | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cpp/cmake_modules/BuildUtils.cmake
b/cpp/cmake_modules/BuildUtils.cmake
index 7c1db67..77db28e 100644
--- a/cpp/cmake_modules/BuildUtils.cmake
+++ b/cpp/cmake_modules/BuildUtils.cmake
@@ -119,9 +119,11 @@ function(ADD_ARROW_LIB LIB_NAME)
set(BUILD_STATIC ${ARROW_BUILD_STATIC})
endif()
- if(MSVC)
+ if(MSVC OR (CMAKE_GENERATOR STREQUAL Xcode))
# MSVC needs to compile C++ separately for each library kind (shared and
static)
# because of dllexport declarations
+ # The Xcode generator doesn't reliably work with Xcode as target names are
not
+ # guessed correctly.
set(LIB_DEPS ${ARG_SOURCES})
set(EXTRA_DEPS ${ARG_DEPENDENCIES})
