[arrow] branch master updated: ARROW-4414: [C++] Stop using cmake COMMAND_EXPAND_LISTS because it breaks package builds for older distros

[uwe]

This is an automated email from the ASF dual-hosted git repository.

uwe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 6626c00  ARROW-4414: [C++] Stop using cmake COMMAND_EXPAND_LISTS 
because it breaks package builds for older distros
6626c00 is described below

commit 6626c009ac19be2fdf5815b70eabbdfdf2b0e434
Author: Krisztián Szűcs <szucs.kriszt...@gmail.com>
AuthorDate: Wed Jan 30 13:33:23 2019 +0100

    ARROW-4414: [C++] Stop using cmake COMMAND_EXPAND_LISTS because it breaks 
package builds for older distros
    
    COMMAND_EXPAND_LISTS option of add_custom_command is too new on Ubuntu 
Xenial and Debian stretch. It's available since CMake 3.8
    
    Linux package builds: 
[kszucs/crossbow/build-434](https://github.com/kszucs/crossbow/branches/all?utf8=%E2%9C%93&query=434)
 (the xenial crossbow error is unrelated)
    
    Author: Krisztián Szűcs <szucs.kriszt...@gmail.com>
    
    Closes #3522 from kszucs/ARROW-4414 and squashes the following commits:
    
    23dde8a3 <Krisztián Szűcs> revert removing cmake from conda_env_cpp
    ca52b309 <Krisztián Szűcs> use system cmake on travis and in docker images; 
remove cmake_expand_lists
---
 ci/travis_script_python.sh                 | 1 -
 cpp/src/gandiva/precompiled/CMakeLists.txt | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/ci/travis_script_python.sh b/ci/travis_script_python.sh
index 60335d9..27d75da 100755
--- a/ci/travis_script_python.sh
+++ b/ci/travis_script_python.sh
@@ -48,7 +48,6 @@ fi
 conda create -y -q -p $CONDA_ENV_DIR \
       --file $TRAVIS_BUILD_DIR/ci/conda_env_python.yml \
       nomkl \
-      cmake \
       pip \
       numpy=1.14 \
       python=${PYTHON_VERSION} \
diff --git a/cpp/src/gandiva/precompiled/CMakeLists.txt 
b/cpp/src/gandiva/precompiled/CMakeLists.txt
index 6e0a092..2b629c7 100644
--- a/cpp/src/gandiva/precompiled/CMakeLists.txt
+++ b/cpp/src/gandiva/precompiled/CMakeLists.txt
@@ -44,8 +44,7 @@ foreach(SRC_FILE ${PRECOMPILED_SRCS})
             -O3 -c ${ABSOLUTE_SRC} -o ${BC_FILE}
             ${ARROW_GANDIVA_PC_CXX_FLAGS}
             -I${CMAKE_SOURCE_DIR}/src
-    DEPENDS ${SRC_FILE}
-    COMMAND_EXPAND_LISTS)
+    DEPENDS ${SRC_FILE})
   list(APPEND BC_FILES ${BC_FILE})
 endforeach()