This is an automated email from the ASF dual-hosted git repository. kszucs pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push: new e70c3a7 ARROW-5823: [Rust] CI scripts miss --all-targets cargo argument e70c3a7 is described below commit e70c3a7ade4b865e41ec862d7a04ef5653f99ec1 Author: Renjie Liu <liurenjie2...@gmail.com> AuthorDate: Tue Jul 2 18:03:15 2019 +0200 ARROW-5823: [Rust] CI scripts miss --all-targets cargo argument Rust build breaks because some changes in array builder. However this error is not detected in ci scripts because missing --all-targets in cargo build command. Author: Renjie Liu <liurenjie2...@gmail.com> Closes #4778 from liurenjie1024/fix-build and squashes the following commits: c00f8bce1 <Renjie Liu> Fix build break --- ci/rust-build-main.bat | 2 +- ci/travis_script_rust.sh | 2 +- rust/arrow/benches/arithmetic_kernels.rs | 1 - rust/arrow/benches/array_from_vec.rs | 1 - rust/arrow/benches/boolean_kernels.rs | 1 - rust/arrow/benches/builder.rs | 2 +- rust/arrow/benches/comparison_kernels.rs | 1 - 7 files changed, 3 insertions(+), 7 deletions(-) diff --git a/ci/rust-build-main.bat b/ci/rust-build-main.bat index 5bf1c84..e7f3c32 100644 --- a/ci/rust-build-main.bat +++ b/ci/rust-build-main.bat @@ -29,7 +29,7 @@ pushd rust rustup default nightly rustup show -cargo build --target %TARGET% --release || exit /B +cargo build --target %TARGET% --all-targets --release || exit /B @echo @echo Test (release) @echo -------------- diff --git a/ci/travis_script_rust.sh b/ci/travis_script_rust.sh index c25d64e..704cb37 100755 --- a/ci/travis_script_rust.sh +++ b/ci/travis_script_rust.sh @@ -31,7 +31,7 @@ rustup show # raises on any formatting errors cargo +stable fmt --all -- --check -RUSTFLAGS="-D warnings" cargo build +RUSTFLAGS="-D warnings" cargo build --all-targets cargo test # run examples diff --git a/rust/arrow/benches/arithmetic_kernels.rs b/rust/arrow/benches/arithmetic_kernels.rs index 855355d..e985168 100644 --- a/rust/arrow/benches/arithmetic_kernels.rs +++ b/rust/arrow/benches/arithmetic_kernels.rs @@ -24,7 +24,6 @@ use std::sync::Arc; extern crate arrow; use arrow::array::*; -use arrow::builder::*; use arrow::compute::array_ops::{limit, sum}; use arrow::compute::kernels::arithmetic::*; use arrow::error::Result; diff --git a/rust/arrow/benches/array_from_vec.rs b/rust/arrow/benches/array_from_vec.rs index f935714..1918e61 100644 --- a/rust/arrow/benches/array_from_vec.rs +++ b/rust/arrow/benches/array_from_vec.rs @@ -22,7 +22,6 @@ use criterion::Criterion; extern crate arrow; use arrow::array::*; -use arrow::array_data::ArrayDataBuilder; use arrow::buffer::Buffer; use arrow::datatypes::*; diff --git a/rust/arrow/benches/boolean_kernels.rs b/rust/arrow/benches/boolean_kernels.rs index d01c9df..3a544ac 100644 --- a/rust/arrow/benches/boolean_kernels.rs +++ b/rust/arrow/benches/boolean_kernels.rs @@ -22,7 +22,6 @@ use criterion::Criterion; extern crate arrow; use arrow::array::*; -use arrow::builder::*; use arrow::compute::kernels::boolean as boolean_kernels; use arrow::error::{ArrowError, Result}; diff --git a/rust/arrow/benches/builder.rs b/rust/arrow/benches/builder.rs index 7036980..c13874b 100644 --- a/rust/arrow/benches/builder.rs +++ b/rust/arrow/benches/builder.rs @@ -25,7 +25,7 @@ use criterion::*; use rand::distributions::Standard; use rand::{thread_rng, Rng}; -use arrow::builder::*; +use arrow::array::*; // Build arrays with 512k elements. const BATCH_SIZE: usize = 8 << 10; diff --git a/rust/arrow/benches/comparison_kernels.rs b/rust/arrow/benches/comparison_kernels.rs index bd75b6a..77f6d83 100644 --- a/rust/arrow/benches/comparison_kernels.rs +++ b/rust/arrow/benches/comparison_kernels.rs @@ -22,7 +22,6 @@ use criterion::Criterion; extern crate arrow; use arrow::array::*; -use arrow::builder::*; use arrow::compute::*; fn create_array(size: usize) -> Float32Array {