This is an automated email from the ASF dual-hosted git repository.

dheres pushed a commit to branch hash_agg_spike
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git

commit 889345c44647096a81f5b3349cb09d584e48c638
Author: Andrew Lamb <[email protected]>
AuthorDate: Sat Jul 1 07:14:54 2023 -0400

    more tests
---
 .../physical-expr/src/aggregate/groups_accumulator/accumulate.rs       | 3 +++
 1 file changed, 3 insertions(+)

diff --git 
a/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs 
b/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs
index 26baad723a..24e4b04661 100644
--- a/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs
+++ b/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs
@@ -82,6 +82,8 @@ pub fn accumulate_all<T, F>(
     // AAL TODO handle filter values
 
     let data: &[T::Native] = values.values();
+    assert_eq!(data.len(), group_indicies.len());
+
     let iter = group_indicies.iter().zip(data.iter());
     for (&group_index, &new_value) in iter {
         value_fn(group_index, new_value)
@@ -113,6 +115,7 @@ pub fn accumulate_all_nullable<T, F>(
 
     // This is based on (ahem, COPY/PASTA) arrow::compute::aggregate::sum
     let data: &[T::Native] = values.values();
+    assert_eq!(data.len(), group_indicies.len());
 
     let group_indices_chunks = group_indicies.chunks_exact(64);
     let data_chunks = data.chunks_exact(64);

Reply via email to