This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 16ca8e08 fix(c/validation): Fix ASAN-detected leak (#879)
16ca8e08 is described below
commit 16ca8e08800d17171e399300a13890dd11ff5e6f
Author: William Ayd <[email protected]>
AuthorDate: Fri Jul 7 07:10:31 2023 -0700
fix(c/validation): Fix ASAN-detected leak (#879)
This started showing up for the timestamp tests. I'm not sure why it
wasn't registering for the primitive types, but I updated both the
timestamp and primitive type tests to Release the statement at end of
use
---
c/validation/adbc_validation.cc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/c/validation/adbc_validation.cc b/c/validation/adbc_validation.cc
index 61f23fff..6a35d6f8 100644
--- a/c/validation/adbc_validation.cc
+++ b/c/validation/adbc_validation.cc
@@ -1023,6 +1023,7 @@ void StatementTest::TestSqlIngestType(ArrowType type,
ASSERT_NO_FATAL_FAILURE(reader.Next());
ASSERT_EQ(nullptr, reader.array->release);
}
+ ASSERT_THAT(AdbcStatementRelease(&statement, &error), IsOkStatus(&error));
}
template <typename CType>
@@ -1162,6 +1163,8 @@ void StatementTest::TestSqlIngestTemporalType() {
ASSERT_NO_FATAL_FAILURE(reader.Next());
ASSERT_EQ(nullptr, reader.array->release);
}
+
+ ASSERT_THAT(AdbcStatementRelease(&statement, &error), IsOkStatus(&error));
}
void StatementTest::TestSqlIngestTimestamp() {
