This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 50493d6d chore(dev/release): fix changelog in GitHub release (#920)
50493d6d is described below
commit 50493d6d1f178fe15e0ed80de9932ef0a2c3b344
Author: David Li <[email protected]>
AuthorDate: Thu Jul 20 13:17:12 2023 -0400
chore(dev/release): fix changelog in GitHub release (#920)
Fixes #460.
---
dev/release/02-sign.sh | 9 ++++++---
docs/source/development/releasing.rst | 2 +-
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/dev/release/02-sign.sh b/dev/release/02-sign.sh
index f81d334f..6267ce84 100755
--- a/dev/release/02-sign.sh
+++ b/dev/release/02-sign.sh
@@ -28,8 +28,9 @@ main() {
exit 1
fi
- local -r version="$1"
- local -r rc_number="$2"
+ local -r prev_version="$1"
+ local -r version="$2"
+ local -r rc_number="$3"
local -r tag="apache-arrow-adbc-${version}-rc${rc_number}"
local -r tarball="apache-arrow-adbc-${version}"
@@ -69,7 +70,9 @@ main() {
--skip-existing
header "Adding release notes"
- local -r release_notes=$(cz ch --dry-run "${tag}" --unreleased-version
"ADBC Libraries ${version}")
+ # XXX: commitizen likes to include the entire history even if we
+ # give it a tag, so we have to give it both tags explicitly
+ local -r release_notes=$(cz ch --dry-run --unreleased-version "ADBC
Libraries ${version}" --start-rev apache-arrow-adbc-${prev_version})
echo "${release_notes}"
gh release edit \
"${tag}" \
diff --git a/docs/source/development/releasing.rst
b/docs/source/development/releasing.rst
index 03bc19b1..cef9fab8 100644
--- a/docs/source/development/releasing.rst
+++ b/docs/source/development/releasing.rst
@@ -160,7 +160,7 @@ Build source and binaries and submit them
# On macOS the only way I could get this to work was running "echo
# "UPDATESTARTUPTTY" | gpg-connect-agent" before running this
# comment otherwise I got errors referencing "ioctl" errors.
- dev/release/02-sign.sh <version> <rc-number>
+ dev/release/02-sign.sh <prev-version> <version> <rc-number>
# Upload the source release tarball and signs to
# https://dist.apache.org/repos/dist/dev/arrow .
