[arrow-adbc] branch main updated: fix(python/adbc_driver_snowflake): allow connecting without URI (#923)

[lidavidm]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new 97593dab fix(python/adbc_driver_snowflake): allow connecting without 
URI (#923)
97593dab is described below

commit 97593dab2ef759feb73ac3adbf860ed2fc1a50db
Author: David Li <li.david...@gmail.com>
AuthorDate: Fri Jul 21 10:37:15 2023 -0400

    fix(python/adbc_driver_snowflake): allow connecting without URI (#923)
    
    Fixes #890.
---
 python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py | 7 ++++---
 python/adbc_driver_snowflake/adbc_driver_snowflake/dbapi.py    | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py 
b/python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py
index 9278c46e..daf88084 100644
--- a/python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py
+++ b/python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py
@@ -108,9 +108,10 @@ def connect(
     db_kwargs : dict, optional
         Initial database connection parameters.
     """
-    return adbc_driver_manager.AdbcDatabase(
-        driver=_driver_path(), uri=uri, **(db_kwargs or {})
-    )
+    kwargs = (db_kwargs or {}).copy()
+    if uri is not None:
+        kwargs["uri"] = uri
+    return adbc_driver_manager.AdbcDatabase(driver=_driver_path(), **kwargs)
 
 
 @functools.cache
diff --git a/python/adbc_driver_snowflake/adbc_driver_snowflake/dbapi.py 
b/python/adbc_driver_snowflake/adbc_driver_snowflake/dbapi.py
index 42b9ec08..d3ad5c4f 100644
--- a/python/adbc_driver_snowflake/adbc_driver_snowflake/dbapi.py
+++ b/python/adbc_driver_snowflake/adbc_driver_snowflake/dbapi.py
@@ -93,7 +93,7 @@ ROWID = adbc_driver_manager.dbapi.ROWID
 
 
 def connect(
-    uri: str,
+    uri: typing.Optional[str] = None,
     db_kwargs: typing.Optional[typing.Dict[str, str]] = None,
     conn_kwargs: typing.Optional[typing.Dict[str, str]] = None,
     **kwargs,
@@ -103,7 +103,7 @@ def connect(
 
     Parameters
     ----------
-    uri : str
+    uri : str, optional
         The URI to connect to.
     db_kwargs : dict, optional
         Initial database connection parameters.