This is an automated email from the ASF dual-hosted git repository.
assignuser pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new b8e450347a MINOR: [C++] Acero tiny typo fix (#36938)
b8e450347a is described below
commit b8e450347ab111a4f8b2fe5134c59235bcd50b20
Author: mwish <[email protected]>
AuthorDate: Wed Aug 2 06:27:12 2023 +0800
MINOR: [C++] Acero tiny typo fix (#36938)
### Rationale for this change
1. Some typo fix in acero
2. move `std::shared_ptr<Schema>` rather than copy
### What changes are included in this PR?
1. Some typo fix in acero
2. move `std::shared_ptr<Schema>` rather than copy
### Are these changes tested?
no
### Are there any user-facing changes?
no
Authored-by: mwish <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
---
cpp/src/arrow/acero/exec_plan.h | 2 +-
cpp/src/arrow/acero/options.h | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/cpp/src/arrow/acero/exec_plan.h b/cpp/src/arrow/acero/exec_plan.h
index 04303aa951..dba6c64ddc 100644
--- a/cpp/src/arrow/acero/exec_plan.h
+++ b/cpp/src/arrow/acero/exec_plan.h
@@ -739,7 +739,7 @@ DeclarationToBatchesAsync(Declaration declaration,
ExecContext exec_context);
/// \brief Utility method to run a declaration and return results as a
RecordBatchReader
///
/// If an exec context is not provided then a default exec context will be
used based
-/// on the value of `use_threads`. If `use_threads` is false then the CPU
exeuctor will
+/// on the value of `use_threads`. If `use_threads` is false then the CPU
executor will
/// be a serial executor and all CPU work will be done on the calling thread.
I/O tasks
/// will still happen on the I/O executor and may be multi-threaded.
///
diff --git a/cpp/src/arrow/acero/options.h b/cpp/src/arrow/acero/options.h
index bb94bdaa4a..1ede3fbfc8 100644
--- a/cpp/src/arrow/acero/options.h
+++ b/cpp/src/arrow/acero/options.h
@@ -80,7 +80,7 @@ class ARROW_ACERO_EXPORT ExecNodeOptions {
///
/// For each batch received a new task will be created to push that batch
downstream.
/// This task will slice smaller units of size `ExecPlan::kMaxBatchSize` from
the
-/// parent batch and call InputRecieved. Thus, if the `generator` yields a
large
+/// parent batch and call InputReceived. Thus, if the `generator` yields a
large
/// batch it may result in several calls to InputReceived.
///
/// The SourceNode will, by default, assign an implicit ordering to outgoing
batches.
@@ -115,7 +115,7 @@ class ARROW_ACERO_EXPORT TableSourceNodeOptions : public
ExecNodeOptions {
/// Create an instance from values
TableSourceNodeOptions(std::shared_ptr<Table> table,
int64_t max_batch_size = kDefaultMaxBatchSize)
- : table(table), max_batch_size(max_batch_size) {}
+ : table(std::move(table)), max_batch_size(max_batch_size) {}
/// \brief a table which acts as the data source
std::shared_ptr<Table> table;
@@ -135,7 +135,7 @@ class ARROW_ACERO_EXPORT NamedTableNodeOptions : public
ExecNodeOptions {
public:
/// Create an instance from values
NamedTableNodeOptions(std::vector<std::string> names,
std::shared_ptr<Schema> schema)
- : names(std::move(names)), schema(schema) {}
+ : names(std::move(names)), schema(std::move(schema)) {}
/// \brief the names to put in the serialized plan
std::vector<std::string> names;
@@ -156,7 +156,7 @@ class ARROW_ACERO_EXPORT SchemaSourceNodeOptions : public
ExecNodeOptions {
/// Create an instance that will create a new task on io_executor for each
iteration
SchemaSourceNodeOptions(std::shared_ptr<Schema> schema, ItMaker it_maker,
arrow::internal::Executor* io_executor)
- : schema(schema),
+ : schema(std::move(schema)),
it_maker(std::move(it_maker)),
io_executor(io_executor),
requires_io(true) {}
@@ -165,7 +165,7 @@ class ARROW_ACERO_EXPORT SchemaSourceNodeOptions : public
ExecNodeOptions {
/// executor
SchemaSourceNodeOptions(std::shared_ptr<Schema> schema, ItMaker it_maker,
bool requires_io = false)
- : schema(schema),
+ : schema(std::move(schema)),
it_maker(std::move(it_maker)),
io_executor(NULLPTR),
requires_io(requires_io) {}