This is an automated email from the ASF dual-hosted git repository. thisisnic pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push: new 45c60ee22b GH-37386: [R] CRAN failures due to "invalid non-character version specification" (#37387) 45c60ee22b is described below commit 45c60ee22ba1a32eb2b5395a45709b5f9eab5c0f Author: Nic Crane <thisis...@gmail.com> AuthorDate: Fri Aug 25 15:44:25 2023 +0100 GH-37386: [R] CRAN failures due to "invalid non-character version specification" (#37387) ### Rationale for this change Package version comparison results in CRAN checks failing due to values being numeric not character ### What changes are included in this PR? Changing numeric values to characters ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: #37386 Authored-by: Nic Crane <thisis...@gmail.com> Signed-off-by: Nic Crane <thisis...@gmail.com> --- r/tests/testthat/test-data-type.R | 2 +- r/tests/testthat/test-schema.R | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/r/tests/testthat/test-data-type.R b/r/tests/testthat/test-data-type.R index 0f193f19d3..e7212eb61b 100644 --- a/r/tests/testthat/test-data-type.R +++ b/r/tests/testthat/test-data-type.R @@ -609,7 +609,7 @@ test_that("DataType$code()", { expect_code_roundtrip(dictionary(index_type = int8(), value_type = large_utf8())) expect_code_roundtrip(dictionary(index_type = int8(), ordered = TRUE)) - skip_if(packageVersion("rlang") < 1) + skip_if(packageVersion("rlang") < "1") # Are these unsupported for a reason? expect_error( eval(DayTimeInterval__initialize()$code()), diff --git a/r/tests/testthat/test-schema.R b/r/tests/testthat/test-schema.R index 77259fb507..db91cee330 100644 --- a/r/tests/testthat/test-schema.R +++ b/r/tests/testthat/test-schema.R @@ -43,7 +43,7 @@ test_that("Schema$code()", { schema(a = int32(), b = struct(c = double(), d = utf8()), e = list_of(binary())) ) - skip_if(packageVersion("rlang") < 1) + skip_if(packageVersion("rlang") < "1") expect_error( eval(schema(x = int32(), y = DayTimeInterval__initialize())$code()), "Unsupported type"