This is an automated email from the ASF dual-hosted git repository.
dheres pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 9b45967edc chore: clean useless clone baesd on clippy (#7973)
9b45967edc is described below
commit 9b45967edc6dba312ea223464dad3e66604d2095
Author: Alex Huang <huangweijun1...@gmail.com>
AuthorDate: Sun Oct 29 22:45:34 2023 +0100
chore: clean useless clone baesd on clippy (#7973)
---
datafusion/core/src/physical_optimizer/combine_partial_final_agg.rs | 2 +-
datafusion/core/src/physical_optimizer/enforce_distribution.rs | 2 +-
datafusion/core/src/physical_optimizer/topk_aggregation.rs | 2 +-
datafusion/physical-expr/src/array_expressions.rs | 2 +-
datafusion/substrait/src/logical_plan/producer.rs | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git
a/datafusion/core/src/physical_optimizer/combine_partial_final_agg.rs
b/datafusion/core/src/physical_optimizer/combine_partial_final_agg.rs
index 838ae61368..2c4e929788 100644
--- a/datafusion/core/src/physical_optimizer/combine_partial_final_agg.rs
+++ b/datafusion/core/src/physical_optimizer/combine_partial_final_agg.rs
@@ -93,7 +93,7 @@ impl PhysicalOptimizerRule for CombinePartialFinalAggregate {
input_agg_exec.filter_expr().to_vec(),
input_agg_exec.order_by_expr().to_vec(),
input_agg_exec.input().clone(),
-
input_agg_exec.input_schema().clone(),
+ input_agg_exec.input_schema(),
)
.ok()
.map(Arc::new)
diff --git a/datafusion/core/src/physical_optimizer/enforce_distribution.rs
b/datafusion/core/src/physical_optimizer/enforce_distribution.rs
index 7b91dce32a..12df9efbbc 100644
--- a/datafusion/core/src/physical_optimizer/enforce_distribution.rs
+++ b/datafusion/core/src/physical_optimizer/enforce_distribution.rs
@@ -554,7 +554,7 @@ fn reorder_aggregate_keys(
agg_exec.filter_expr().to_vec(),
agg_exec.order_by_expr().to_vec(),
partial_agg,
- agg_exec.input_schema().clone(),
+ agg_exec.input_schema(),
)?);
// Need to create a new projection to change the expr
ordering back
diff --git a/datafusion/core/src/physical_optimizer/topk_aggregation.rs
b/datafusion/core/src/physical_optimizer/topk_aggregation.rs
index 572e796a8b..e0a8da82e3 100644
--- a/datafusion/core/src/physical_optimizer/topk_aggregation.rs
+++ b/datafusion/core/src/physical_optimizer/topk_aggregation.rs
@@ -75,7 +75,7 @@ impl TopKAggregation {
aggr.filter_expr().to_vec(),
aggr.order_by_expr().to_vec(),
aggr.input().clone(),
- aggr.input_schema().clone(),
+ aggr.input_schema(),
)
.expect("Unable to copy Aggregate!")
.with_limit(Some(limit));
diff --git a/datafusion/physical-expr/src/array_expressions.rs
b/datafusion/physical-expr/src/array_expressions.rs
index 7077f8b598..84fd301b84 100644
--- a/datafusion/physical-expr/src/array_expressions.rs
+++ b/datafusion/physical-expr/src/array_expressions.rs
@@ -811,7 +811,7 @@ fn concat_internal(args: &[ArrayRef]) -> Result<ArrayRef> {
}
}
// Assume all arrays have the same data type
- let data_type = list_arrays[0].value_type().clone();
+ let data_type = list_arrays[0].value_type();
let buffer = valid.finish();
let elements = arrays
diff --git a/datafusion/substrait/src/logical_plan/producer.rs
b/datafusion/substrait/src/logical_plan/producer.rs
index 757bddf9fe..e3c6f94d43 100644
--- a/datafusion/substrait/src/logical_plan/producer.rs
+++ b/datafusion/substrait/src/logical_plan/producer.rs
@@ -326,7 +326,7 @@ pub fn to_substrait_rel(
left: Some(left),
right: Some(right),
r#type: join_type as i32,
- expression: join_expr.clone(),
+ expression: join_expr,
post_join_filter: None,
advanced_extension: None,
}))),
