AlenkaF commented on PR #484: URL: https://github.com/apache/arrow-site/pull/484#issuecomment-1987929841
Oh, too bad. If I understand correctly, the change added here: https://github.com/apache/arrow/pull/39762 also affects the docs being built for minor releases but since these are not moved to a separate folder they should not include the change - neither `DOCUMENTATION_OPTIONS.theme_switcher_version_match` nor `DOCUMENTATION_OPTIONS.show_version_warning_banner`. The first change, `DOCUMENTATION_OPTIONS.theme_switcher_version_match`, is also necessary I think because when the current stable docs will be copied to a subfolder (`15.0`) the version displayed on the banner will currently be `15.0.1` instead for `15.0`. I guess we need to add something like `if [ "$is_major_release" = "yes" ] ; then [...] fi` to the code we added in https://github.com/apache/arrow/pull/39762. Will make an issue and a PR for it, if my understanding is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
