This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 06f0e0c708 GH-41119: [Archery][Packaging][CI] Avoid using --progress 
flag on Docker on Windows on archery (#41120)
06f0e0c708 is described below

commit 06f0e0c7088b571a2265e116893a03cda0a919ab
Author: Raúl Cumplido <[email protected]>
AuthorDate: Wed Apr 10 23:04:51 2024 +0200

    GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on 
Windows on archery (#41120)
    
    ### Rationale for this change
    
    Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` 
by default. This uses `--progress` on `docker build` which is not supported on 
Windows.
    
    ### What changes are included in this PR?
    
    Do not use `--progress` on the Windows builds.
    
    ### Are these changes tested?
    
    Yes on CI via archery.
    
    ### Are there any user-facing changes?
    No
    * GitHub Issue: #41119
    
    Lead-authored-by: Raúl Cumplido <[email protected]>
    Co-authored-by: Sutou Kouhei <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 dev/archery/archery/docker/core.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dev/archery/archery/docker/core.py 
b/dev/archery/archery/docker/core.py
index 0b49111dd6..7376bb0a3b 100644
--- a/dev/archery/archery/docker/core.py
+++ b/dev/archery/archery/docker/core.py
@@ -311,7 +311,7 @@ class DockerCompose(Command):
                 self._execute_docker("buildx", "build", *args)
             elif self.config.using_docker:
                 # better for caching
-                if self.config.debug:
+                if self.config.debug and os.name != "nt":
                     args.append("--progress=plain")
                 for k, v in service['build'].get('args', {}).items():
                     args.extend(['--build-arg', '{}={}'.format(k, v)])
@@ -324,7 +324,7 @@ class DockerCompose(Command):
                 ])
                 self._execute_docker("build", *args)
             else:
-                if self.config.debug:
+                if self.config.debug and os.name != "nt":
                     args.append("--progress=plain")
                 self._execute_compose("build", *args, service['name'])
 

Reply via email to